Treat mailer as first class citizen in new app #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonganger
force-pushed
the
custom/patch-3
branch
3 times, most recently
from
d6ac988
to
08a2791
Compare
|
cc @elorest @drujensen @eliasjpr I like this. The default state of a webapp these days is to send email, so I think it makes sense. |
eliasjpr
reviewed
Jan 23, 2019
westonganger
force-pushed
the
custom/patch-3
branch
from
11c8a46
to
193efbf
Compare
|
Updated. Specs are now passing. |
eliasjpr
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the mailer initializers and files are only added if you use the generator which is super confusing for people who do it by hand.
The mailer should be treated as a first class citizen. Lets make the mailer opt-out instead of opt-in. If an application does not need the mailer they can comment out the initializer or delete it.
Fixes #1031
I will create a PR to update the docs accordingly afterwards.